Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci to v1.20 #8432

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@kolaente
Copy link
Member

commented Oct 8, 2019

As title.

kolaente and others added 3 commits Oct 8, 2019
Signed-off-by: kolaente <k@knt.li>
Signed-off-by: kolaente <k@knt.li>
@lafriks
lafriks approved these changes Oct 8, 2019
@GiteaBot GiteaBot added the lgtm/need 1 label Oct 8, 2019
@lafriks lafriks added the kind/lint label Oct 8, 2019
@lafriks lafriks added this to the 1.10.0 milestone Oct 8, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 8, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #8432 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8432      +/-   ##
=========================================
+ Coverage    41.8%   41.8%   +<.01%     
=========================================
  Files         497     497              
  Lines       65631   65631              
=========================================
+ Hits        27438   27439       +1     
+ Misses      34680   34676       -4     
- Partials     3513    3516       +3
Impacted Files Coverage Δ
models/repo_indexer.go 68.21% <0%> (-1.94%) ⬇️
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️
routers/repo/view.go 43.32% <0%> (+1%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05a335...fdc11d7. Read the comment docs.

@techknowlogick techknowlogick merged commit 7408942 into go-gitea:master Oct 8, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.