Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backports] [Partial] of #9550 #9564

Merged
merged 1 commit into from
Dec 31, 2019
Merged

[Backports] [Partial] of #9550 #9564

merged 1 commit into from
Dec 31, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 31, 2019

backport #9550

@6543
backport part of go-gitea#9550
5884e22 
 * add ErrReactionAlreadyExist
 * extend FindReactionsOptions
 * createReaction check if exit before create
@6543 6543 changed the title [Backports] [API] Fix 9544 | return 200 when reaction already exist [Backports] [Partial] of #9550 Dec 31, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 31, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2019
@lafriks lafriks added this to the 1.10.2 milestone Dec 31, 2019
@lafriks lafriks merged commit c63a801 into go-gitea:release/v1.10 Dec 31, 2019
@6543 6543 deleted the backports_9550 branch December 31, 2019 18:47
@6543 6543 mentioned this pull request Jan 2, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lafriks @zeripath @GiteaBot