New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL 4.6 support. #90

Closed
dmitshur opened this Issue Nov 10, 2017 · 11 comments

Comments

Projects
None yet
3 participants
@dmitshur
Member

dmitshur commented Nov 10, 2017

When I did glow download in #89, it fetched the latest XML from our current source at https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/gl.xml:

$ glow download
2017/11/09 19:51:41 Downloading https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/wgl.xml
2017/11/09 19:51:41 Downloading https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/gl.xml
2017/11/09 19:51:41 Downloading https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/egl.xml
2017/11/09 19:51:41 Downloading https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/glx.xml
...

However, even the latest version of that repository, at this moment, does not yet contain definitions for OpenGL 4.6. It contains 4.5 as the latest version.

The alternative source at https://raw.githubusercontent.com/KhronosGroup/OpenGL-Registry/master/xml/gl.xml that @kjozic found contains 4.6.

We need to decide what to do to add support for OpenGL 4.6 to glow:

  1. Do we wait until the current source adds 4.6? Any way to find out when that will happen?
  2. Do we change the default source where we fetch our XML files? But what about the doc XML files and egl.xml which isn't present in https://github.com/KhronosGroup/OpenGL-Registry/tree/master/xml?

/cc @errcw Need your input on this decision.

This was referenced Nov 10, 2017

@errcw

This comment has been minimized.

Show comment
Hide comment
@errcw

errcw Nov 10, 2017

Member

I believe the right answer is to change the default source where we fetch the XML files. It appears that Khronos maintains its GitHub repositories but not its SVN ones. Unfortunately it means pulling the files from more locations. The docs appear to be located in https://github.com/KhronosGroup/OpenGL-Refpages, and egl.xml appears to be located in https://github.com/KhronosGroup/EGL-Registry. Perhaps the easiest answer is to remove the download command and instead add documentation from where to fetch the files?

Member

errcw commented Nov 10, 2017

I believe the right answer is to change the default source where we fetch the XML files. It appears that Khronos maintains its GitHub repositories but not its SVN ones. Unfortunately it means pulling the files from more locations. The docs appear to be located in https://github.com/KhronosGroup/OpenGL-Refpages, and egl.xml appears to be located in https://github.com/KhronosGroup/EGL-Registry. Perhaps the easiest answer is to remove the download command and instead add documentation from where to fetch the files?

@kjozic

This comment has been minimized.

Show comment
Hide comment
@kjozic

kjozic Nov 15, 2017

Contributor

I rewrote main.go and download.go (link, branch OpenGL4.6) to fetch the XML files from GitHub but there is a problem with hourly rate limit. For unauthenticated requests, the rate limit is 60 requests per hour which is not enough to download all the files.

Contributor

kjozic commented Nov 15, 2017

I rewrote main.go and download.go (link, branch OpenGL4.6) to fetch the XML files from GitHub but there is a problem with hourly rate limit. For unauthenticated requests, the rate limit is 60 requests per hour which is not enough to download all the files.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Nov 17, 2017

Member

We can make it a requirement to supply a github token to get the authenticated rate limit of 5000 per hour.

Member

dmitshur commented Nov 17, 2017

We can make it a requirement to supply a github token to get the authenticated rate limit of 5000 per hour.

@kjozic

This comment has been minimized.

Show comment
Hide comment
@kjozic

kjozic Nov 17, 2017

Contributor

I made support for GitHub basic auth.

Contributor

kjozic commented Nov 17, 2017

I made support for GitHub basic auth.

@errcw

This comment has been minimized.

Show comment
Hide comment
@errcw

errcw Feb 18, 2018

Member

I'm attempting to resolve this in #92.

Member

errcw commented Feb 18, 2018

I'm attempting to resolve this in #92.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Feb 19, 2018

Member

@errcw Did you see #91 before making #92? If so, can you explain in what ways do they differ?

Member

dmitshur commented Feb 19, 2018

@errcw Did you see #91 before making #92? If so, can you explain in what ways do they differ?

@errcw

This comment has been minimized.

Show comment
Hide comment
@errcw

errcw Feb 19, 2018

Member

Alas, no. I commented on that review. I'll drop #92 once #91 goes in.

Member

errcw commented Feb 19, 2018

Alas, no. I commented on that review. I'll drop #92 once #91 goes in.

@kjozic

This comment has been minimized.

Show comment
Hide comment
@kjozic

kjozic Feb 22, 2018

Contributor

When I try to download gl.xml, the empty file is returned. The cause of the error is the file size:

{
  "message": "This API returns blobs up to 1 MB in size. The requested blob is too large to fetch via the API, but you can use the Git Data API to request blobs up to 100 MB in size.",
  "errors": [
    {
      "resource": "Blob",
      "field": "data",
      "code": "too_large"
    }
  ],
  "documentation_url": "https://developer.github.com/v3/repos/contents/#get-contents"
}

Please check the pull request "Add support for download of files larger than 1 MB.".

Contributor

kjozic commented Feb 22, 2018

When I try to download gl.xml, the empty file is returned. The cause of the error is the file size:

{
  "message": "This API returns blobs up to 1 MB in size. The requested blob is too large to fetch via the API, but you can use the Git Data API to request blobs up to 100 MB in size.",
  "errors": [
    {
      "resource": "Blob",
      "field": "data",
      "code": "too_large"
    }
  ],
  "documentation_url": "https://developer.github.com/v3/repos/contents/#get-contents"
}

Please check the pull request "Add support for download of files larger than 1 MB.".

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Mar 3, 2018

Member

Is this issue resolved by #91 and #94 (which have been merged by now)?

Member

dmitshur commented Mar 3, 2018

Is this issue resolved by #91 and #94 (which have been merged by now)?

@kjozic

This comment has been minimized.

Show comment
Hide comment
@kjozic

kjozic Mar 4, 2018

Contributor

Yes. You can close the issue.

Contributor

kjozic commented Mar 4, 2018

Yes. You can close the issue.

@dmitshur dmitshur closed this Mar 4, 2018

dmitshur added a commit that referenced this issue Mar 4, 2018

Download latest XML data.
Use glow download to fetch the latest XML data.

This is needed to be able to generate OpenGL 4.6 gl packages.

Updates #90.
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Mar 4, 2018

Member

We should download and commit the latest XML from the new source to fully resolve this issue. Reopening for that.

Member

dmitshur commented Mar 4, 2018

We should download and commit the latest XML from the new source to fully resolve this issue. Reopening for that.

@dmitshur dmitshur reopened this Mar 4, 2018

@errcw errcw closed this in #95 Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment