Use uint8 for GLchar and GLcharARB. Fix #47. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be a compile time error that's easy to spot and fix, right? |
|
Yep, it should be a trivial fix for code hurt by this delta. |
|
Great. The change in this PR leads to a better API. LGTM. |
errcw
added a commit
that referenced
this pull request
Nov 15, 2014
Use uint8 for GLchar and GLcharARB. Fix #47.
|
This looks great! I am really glad you worked out a solution to this. LGTM =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #47 use
uint8forGLcharinstead ofint8. Preferuint8overbytebecause some GL functions, such asglGetStringuseGLubyterather thanGLchar.My only hesitation is that this change represents an API change that has the possibility of breaking client code. I expect the majority of use cases to be funneled through
gl.Strwhich makes the change transparent but any direct string manipulation will be affected.