Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Redact Database Password from Errors #6827

Closed
garrettladley opened this issue Feb 5, 2024 · 1 comment
Closed

Security: Redact Database Password from Errors #6827

garrettladley opened this issue Feb 5, 2024 · 1 comment
Assignees
Labels
type:feature_request feature request

Comments

@garrettladley
Copy link

garrettladley commented Feb 5, 2024

Describe the feature

Provide the ability to hide the database password from logs/error messages. Perhaps as an additional field in gorm.Config, perhaps as an option within struct tags (@DOOduneye), or both.

Motivation

This would enhance security by preventing sensitive database passwords from being exposed in error messages. Currently, when an error occurs in database interactions, the password may inadvertently appear in error logs or messages, posing a potential security risk. Adding an additional field in gorm.Config to hide the database password will help mitigate this risk and improve overall system security.

Adding this as an option that defaults to hiding the password, then opting in to showing it will provide a guardrail for gorm users. Or at a more granular level with struct tags will help prevent inadvertent secret leaking.

Related Issues

See @ctholho 's issue in postgres

@jinzhu
Copy link
Member

jinzhu commented Jun 12, 2024

We do not log any information. The error mentioned above comes from the driver, so it should be addressed and fixed within the driver itself.

@jinzhu jinzhu closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature_request feature request
Projects
None yet
Development

No branches or pull requests

2 participants