carbonserver: log more detailed errors about symlink and continue trie index despite error #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e index despite error Two issues are resolved in this commit: * filepath.Walk does not follow symlinks, so it is good practice to log errors during startup and indexing when whisper data dir is a symlink. * trie.insert could return errors if broken filename or paths or bugs are encountered or triggered. originally it would stop indexing when error is returned for a specific metric path, but it is better to continue indexing and just log the error.
It is not an intended use case of trie index, but it is nice to have it cope properly when inserting dirs instead of files.
deniszh
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues are resolved in this commit:
and indexing when whisper data dir is a symlink.
triggered. originally it would stop indexing when error is returned for a specific metric
path, but it is better to continue indexing and just log the error.