Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carbonserver: log more detailed errors about symlink and continue trie index despite error #427

Merged
merged 2 commits into from
Sep 30, 2021
Merged

carbonserver: log more detailed errors about symlink and continue trie index despite error #427

merged 2 commits into from
Sep 30, 2021

Commits on Aug 11, 2021

  1. carbonserver: log more detailed errors about symlink and continue tri… 

    …e index despite error

Two issues are resolved in this commit:

* filepath.Walk does not follow symlinks, so it is good practice to log errors during startup
  and indexing when whisper data dir is a symlink.
* trie.insert could return errors if broken filename or paths or bugs are encountered or
  triggered. originally it would stop indexing when error is returned for a specific metric
  path, but it is better to continue indexing and just log the error.
    @bom-d-van
    bom-d-van committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    4f1ebd4 View commit details
    Browse the repository at this point in the history

  2. trie: fix dir insert 

    It is not an intended use case of trie index, but it is nice to have it cope properly
when inserting dirs instead of files.
    @bom-d-van
    bom-d-van committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    488ad5a View commit details
    Browse the repository at this point in the history