Fixed the problem with different number of metrics in trie index and on disk #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isk, moved creation throttle logic to trie index. fixed a bug in hard throttle helper
Changed an order of applying throttle func (how it was before): first throughput throttle, second quota usage throttle, third hard throttle
deniszh
approved these changes
Oct 7, 2022
azhiltsov
approved these changes
Oct 7, 2022
grzkv
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to merge previous MR which I had to revert.
The problem was that creation throttle was happening much more often than with previous design.
Mainly because with previous design throughput throttle and quota usage throttle happened before the creation throttle, which allowed us to save creation throttle quota. In this MR I change the order of throttle function as it was before.