cleanup: remove <requestType>Errors metrics in favour of status_codes.* ones as more reliable #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtofan
force-pushed
the
atimofieiev/deprecate-error-metrics
branch
3 times, most recently
from
9baba14
to
0c92755
Compare
timtofan
changed the title
timtofan
changed the title
….* ones as more reliable In our clusters FindErrors erroneously showed zero while there were lots of http404s. In general those metrics are less reliable than status_codes.* ones since they depend on having code to increment it on each error scenario which is easy to miss.
timtofan
force-pushed
the
atimofieiev/deprecate-error-metrics
branch
from
0c92755
to
a01bc52
Compare
emadolsky
approved these changes
Feb 8, 2023
deniszh
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our clusters FindErrors erroneously showed zero while there were lots of http404s.
In general those metrics are less reliable than status_codes.* ones since they depend on having code to increment it on each error scenario which is easy to miss.