Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove <requestType>Errors metrics in favour of status_codes.* ones as more reliable #523

Merged
merged 1 commit into from
Feb 8, 2023
Merged

cleanup: remove <requestType>Errors metrics in favour of status_codes.* ones as more reliable #523

merged 1 commit into from
Feb 8, 2023

Commits on Feb 8, 2023

  1. cleanup: remove <requestType>Errors metrics in favour of status_codes… 

    ….* ones as more reliable

In our clusters FindErrors erroneously showed zero while there were lots of http404s.
In general those metrics are less reliable than status_codes.* ones since they depend on having code to increment it on each error scenario which is easy to miss.
    Anton Timofieiev committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a01bc52 View commit details
    Browse the repository at this point in the history