Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

2/4 - Implement native compilation - Implement boilerplate. #112

Merged
merged 11 commits into from
Apr 1, 2019
Merged

2/4 - Implement native compilation - Implement boilerplate. #112

merged 11 commits into from
Apr 1, 2019

Conversation

twitchyliquid64
Copy link
Contributor

Please review the previous PR first - this builds off that.

@codecov-io
Copy link

codecov-io commented Mar 24, 2019 •
edited

Codecov Report

Merging #112 into master will decrease coverage by 1.1%.
The diff coverage is 20.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   68.87%   67.76%   -1.11%     
==========================================
  Files          33       34       +1     
  Lines        3351     3425      +74     
==========================================
+ Hits         2308     2321      +13     
- Misses        785      844      +59     
- Partials      258      260       +2
Impacted Files Coverage Δ
wasm/operators/op.go 75% <0%> (ø) ⬆️
exec/func.go 76% <100%> (+0.48%) ⬆️
exec/native_compile.go 4% <4%> (ø)
exec/vm.go 82.28% <50%> (-3.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc960d5...d973a5b. Read the comment docs.

sbinet
sbinet reviewed Apr 1, 2019
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a first pass

exec/internal/compile/compile.go Outdated Show resolved Hide resolved
exec/internal/compile/compile.go Outdated Show resolved Hide resolved
exec/internal/compile/scanner.go Outdated Show resolved Hide resolved
exec/internal/compile/scanner.go Show resolved Hide resolved
exec/internal/compile/scanner.go Show resolved Hide resolved
exec/vm.go Outdated Show resolved Hide resolved
exec/internal/compile/scanner.go Outdated Show resolved Hide resolved
exec/vm.go Outdated Show resolved Hide resolved
exec/native_compile.go Outdated Show resolved Hide resolved
exec/native_compile.go Outdated Show resolved Hide resolved
@twitchyliquid64
Copy link
Contributor Author

😄 ✈️

@sbinet
Copy link
Contributor

sbinet commented Apr 1, 2019

please rebase on top the latest master. thanks.

Tom and others added 4 commits April 1, 2019 10:42
Final fixes
56537a1
@twitchyliquid64
exec: fix stack allocation & depths, add debug mode to find these issues
8d2dbf4 
* Fix stack allocation & depths, add debug mode to find these issues.

* Make CI run tests with debugStackDepth = true.

* Implement review feedback.

* Final fixes
Merge remote-tracking branch 'upstream/master' into HEAD
993fc73
Merge commit '993fc73a0e709b470a9344a322164ad609743c1e' into compiler_1
d973a5b
@twitchyliquid64
Copy link
Contributor Author

Okay, I think I got that to work at the expense of the commit history (I think that can be squashed at merge?), LGTU?

sbinet
sbinet approved these changes Apr 1, 2019
View reviewed changes
exec/exec_test.go Show resolved Hide resolved
@sbinet sbinet merged commit ca24328 into go-interpreter:master Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbinet sbinet sbinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twitchyliquid64 @codecov-io @sbinet