exec: fix div instruction #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
- Coverage 69.77% 69.03% -0.74%
==========================================
Files 49 51 +2
Lines 5495 5910 +415
==========================================
+ Hits 3834 4080 +246
- Misses 1318 1467 +149
- Partials 343 363 +20
Continue to review full report at Codecov.
|
|
@sbinet ,review? |
|
No rush to merge. we have build a test runner for the spec testsuite in our forked repo, |
# Conflicts: # exec/memory.go
# Conflicts: # .gitignore # wasm/calibration.go
# Conflicts: # tests/spectestcase # wasm/index.go
|
ping? |
# Conflicts: # exec/num_test.go
|
@sbinet sorry for late reply. Have appended commits for test runner and some bug fix. |
| @@ -0,0 +1,3 @@ | |||
| [submodule "tests/spectestcase"] | |||
| path = tests/spectestcase | |||
| url = https://github.com/ontio/testsuite | |||
There was a problem hiding this comment.
Our forked testsuite disabled all testcases related to floating-point operation and I do not have enough time to check that part. We can replace it with https://github.com/WebAssembly/testsuite and fix the floating-point operation in other PR.
There was a problem hiding this comment.
it seems we've grown too many "testsuite" datasets over time...
perhaps not for this PR, but it would be great to streamline a bit all of those...
| @@ -0,0 +1,3 @@ | |||
| [submodule "tests/spectestcase"] | |||
| path = tests/spectestcase | |||
| url = https://github.com/ontio/testsuite | |||
There was a problem hiding this comment.
it seems we've grown too many "testsuite" datasets over time...
perhaps not for this PR, but it would be great to streamline a bit all of those...
| } | ||
| } | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
couldn't we pre-generate the .json files (via a go generate command) and make this run as part of the usual testing.T infrastructure?
Co-Authored-By: Sebastien Binet <binet@cern.ch>
spec ref: https://webassembly.github.io/spec/core/exec/numerics.html#op-idiv-s
this fix passed the testcase in https://github.com/WebAssembly/testsuite/blob/master/i32.wast#L64