replace env underscore to dot #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lint没过，这里replace完是不是要赋值回去 |
|
感觉这里应该在env source里面处理的？ |
是啊，现在就是env.go里处理的 |
其实最好是统一在上层处理？上层应该告诉下层需要用什么来分割，并且这个分割符可以配置 |
tonybase
approved these changes
Jul 23, 2021
tonybase
added a commit
that referenced
this pull request
Jul 23, 2021
elvizlai
pushed a commit
to elvizlai/kratos
that referenced
this pull request
Aug 2, 2021
* replace env underscore to dot * Compatible with dot format
elvizlai
pushed a commit
to elvizlai/kratos
that referenced
this pull request
Aug 2, 2021
This reverts commit 38c9def.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
因为 . 在env里是非法字符，一般会用_来代替.的，所以需要替换回来
这样可以正确获取到 aa.bbb.ccc的value了