Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registry): consul client add DeregisterCriticalServiceAfter option #1917

Merged
merged 2 commits into from Apr 10, 2022
Merged

feat(registry): consul client add DeregisterCriticalServiceAfter option #1917

merged 2 commits into from Apr 10, 2022

Conversation

Casper-Mars
Copy link
Contributor

Description (what this PR does / why we need it):

Add DeregisterCriticalServiceAfter option

Which issue(s) this PR fixes (resolves / be part of):

fixes #1904

@Casper-Mars Casper-Mars changed the title Feat(registry/consul):consul client add DeregisterCriticalServiceAfter option feat(registry): consul client add DeregisterCriticalServiceAfter option Apr 8, 2022
@tonybase tonybase merged commit 19637d9 into main Apr 10, 2022
@tonybase tonybase deleted the consul_option branch April 10, 2022 08:14
tonybase pushed a commit that referenced this pull request May 31, 2022
@Casper-Mars @tonybase
feat(registry): consul client add DeregisterCriticalServiceAfter opti…
64c4417 
…on (#1917)

* feat(registry/consul):add DeregisterCriticalServiceAfter option

* fix(cmd/protoc-gen-go-errors):fix lint problem (#1919)

use cases.Title instead of strings.Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonybase tonybase tonybase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal]DeregisterCriticalServiceAfter should be configured independently
2 participants
@Casper-Mars @tonybase