Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): fix lint problem #1919

Merged
merged 1 commit into from Apr 8, 2022
Merged

fix(cmd): fix lint problem #1919

merged 1 commit into from Apr 8, 2022

Conversation

Casper-Mars
Copy link
Contributor

Description (what this PR does / why we need it):

fix lint problem

Which issue(s) this PR fixes (resolves / be part of):

fixes #1918

use cases.Title instead of strings.Title
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #1919 (a67cfa5) into main (d5a2fb5) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
- Coverage   80.65%   80.59%   -0.06%     
==========================================
  Files          81       81              
  Lines        3587     3587              
==========================================
- Hits         2893     2891       -2     
- Misses        487      489       +2     
  Partials      207      207              
Impacted Files Coverage Δ
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a2fb5...a67cfa5. Read the comment docs.

@Casper-Mars Casper-Mars changed the title Fix(cmd/protoc-gen-go-errors):fix lint problem fix(cmd/protoc-gen-go-errors):fix lint problem Apr 8, 2022
@Casper-Mars Casper-Mars changed the title fix(cmd/protoc-gen-go-errors):fix lint problem fix:fix lint problem Apr 8, 2022
@Casper-Mars Casper-Mars changed the title fix:fix lint problem fix(cmd/protoc-gen-go-errors):fix lint problem Apr 8, 2022
@Casper-Mars Casper-Mars changed the title fix(cmd/protoc-gen-go-errors):fix lint problem fix(cmd):fix lint problem Apr 8, 2022
@Casper-Mars Casper-Mars changed the title fix(cmd):fix lint problem fix(cmd): fix lint problem Apr 8, 2022
@tonybase tonybase merged commit 4f21094 into main Apr 8, 2022
@tonybase tonybase deleted the strings_title_deprecated branch April 8, 2022 08:20
Casper-Mars added a commit that referenced this pull request Apr 8, 2022
use cases.Title instead of strings.Title
Casper-Mars added a commit that referenced this pull request Apr 8, 2022
use cases.Title instead of strings.Title
tonybase pushed a commit that referenced this pull request Apr 10, 2022
…on (#1917)

* feat(registry/consul):add DeregisterCriticalServiceAfter option

* fix(cmd/protoc-gen-go-errors):fix lint problem (#1919)

use cases.Title instead of strings.Title
tonybase pushed a commit that referenced this pull request Apr 10, 2022
* feat(README):change description of Kratos

* fix(cmd/protoc-gen-go-errors):fix lint problem (#1919)

use cases.Title instead of strings.Title
tonybase pushed a commit that referenced this pull request May 31, 2022
use cases.Title instead of strings.Title
tonybase pushed a commit that referenced this pull request May 31, 2022
…on (#1917)

* feat(registry/consul):add DeregisterCriticalServiceAfter option

* fix(cmd/protoc-gen-go-errors):fix lint problem (#1919)

use cases.Title instead of strings.Title
tonybase pushed a commit that referenced this pull request May 31, 2022
* feat(README):change description of Kratos

* fix(cmd/protoc-gen-go-errors):fix lint problem (#1919)

use cases.Title instead of strings.Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint issue of the deprecated method "strings.Title"
4 participants