fix(kratos/registry/registry.go): Kratos's ServiceInstance does not i… #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplement an Equal method for grpc's Attributes. Description (what this PR does / why we need it): It will help the grpc resolver to work correctly. If we don't do this, because the grpc parser cannot correctly determine whether the node already exists, and every time the service discovery generates an event, it will establish a connection with all the nodes in the event and release the previously existing node even if it is in the new event exists in. [resolver.go](https://github.com/go-kratos/kratos/blob/b3eff576ce0d5cbadf53ec2a9ab1232d45e5cef3/transport/grpc/resolver/discovery/resolver.go#L70) [balancer.go](https://github.com/grpc/grpc-go/blob/master/balancer/base/balancer.go#L106) [map.go](https://github.com/grpc/grpc-go/blob/master/resolver/map.go#L60) [resolver.go](https://github.com/grpc/grpc-go/blob/master/resolver/resolver.go#L143) [attributes.go](https://github.com/grpc/grpc-go/blob/master/attributes/attributes.go#L91) Which issue(s) this PR fixes (resolves / be part of): Other special notes for the reviewers:
Codecov Report
@@ Coverage Diff @@
## main #2575 +/- ##
=======================================
Coverage 85.16% 85.16%
=======================================
Files 88 88
Lines 3835 3835
=======================================
Hits 3266 3266
Misses 396 396
Partials 173 173 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
longXboy
approved these changes
Dec 16, 2022
xiongpan828
pushed a commit
to xiongpan828/kratos
that referenced
this pull request
Jan 5, 2023
… grpc Attributes. (go-kratos#2575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kratos's ServiceInstance does not implement an Equal method for grpc's Attributes.
Description (what this PR does / why we need it):
It will help the grpc resolver to work correctly.
If we don't do this, the grpc resolver cannot correctly determine whether the node already exists, and every time the service discovery generates an event, it will establish a connection with all the nodes in the event and release the previously existing node even if it is in the new event exists in.
resolver.go
balancer.go
map.go
resolver.go
attributes.go
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers:
Description (what this PR does / why we need it):
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: