Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment count mismatch inspection #2330

Closed
wants to merge 2 commits into from
Closed

Assignment count mismatch inspection #2330

wants to merge 2 commits into from

Conversation

dlsniper
Copy link
Member

@dlsniper dlsniper commented Feb 7, 2016

fixes #1219
fixes #1842
fixes #1906

@dlsniper
Copy link
Member Author

dlsniper commented Feb 7, 2016

I've yet to run the tests locally so I'll the CI do this for me.

@zolotov
Copy link
Contributor

zolotov commented Feb 7, 2016

@dlsniper what's wrong with your local running? There is no difference between local and CI running, both uses gradlew-script

@dlsniper
Copy link
Member Author

dlsniper commented Feb 7, 2016

@zolotov I'm running on IDEA 16 EAP and for some reason (Kotlin differences) nothing that's based against master (IDEA 15) works, either when running ./gradlew runIdea or ./gradlew cleanTest test. I could jump to IDEA 15 and do it but it's a bit more work to jump versions (I'll do it if something fails on the CI run, ofc).

@zolotov
Copy link
Contributor

zolotov commented Feb 7, 2016

Running tests and gradlew script have nothing to do with the IDEA you're running on, try to clean gradles cache (~/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/) in case you replaced kotlin runtime libraries.

@dlsniper
Copy link
Member Author

dlsniper commented Feb 7, 2016

That worked, thank you. I can run tests from the command line (and IDE) now.


if (type.getParent() instanceof GoParameterDeclaration &&
type.getParent().getParent() instanceof GoParameters) {
parentFunc = type.getParent().getParent().getParent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you kidding? :) type.getParent().getParent().getParent()

@dlsniper
Copy link
Member Author

Hi @ignatov, sorry for delay, I've updated the PR per review feedback. Thank you

@dlsniper
Copy link
Member Author

as this is beyond huge / ugly, I'll close it for now to declutter the list of PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants