Refactor the context handling with receiving an ldap response in searchAsync() #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuschma
requested changes
Apr 1, 2024
| @@ -102,9 +102,7 @@ func (r *searchResponse) start(ctx context.Context, searchRequest *SearchRequest | |||
| case <-ctx.Done(): | |||
| r.conn.Debug.Printf("%d: %s", msgCtx.id, ctx.Err().Error()) | |||
| return | |||
| default: | |||
| r.conn.Debug.Printf("%d: waiting for response", msgCtx.id) | |||
There was a problem hiding this comment.
I suggest you move the debug line above the select statement instead of erasing it completely:
foundSearchSingleResultDone := false
for !foundSearchSingleResultDone {
r.conn.Debug.Printf("%d: waiting for response", msgCtx.id)
select {
case <-ctx.Done():...
cpuschma
approved these changes
Apr 1, 2024
gustavoluvizotto
pushed a commit
to gustavoluvizotto/ldap-fork
that referenced
this pull request
Apr 11, 2024
…chAsync() (go-ldap#496) * Refactor the context handling with receiving an ldap response in searchAsync() go-ldap#495 * Add debug print for response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SaschaRoland suggested refactoring context handling in #495. This change enables context-based canceling while receiving an LDAP response.