Adding the option to use an fs.FS for the file server middleware
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .gitattributes where EOL is set to LF for testdata in file package so that tests would not fail on Windows systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the option
FSto theServerOptionsof the file server middleware which allows passing anfs.FSas content root.For example, this makes it possible to use static web files directly compiled into the binary using
embed.FS.When the
FSfield is specified, this overrides the setRootPath. Otherwise, whenFSis not specified, the given (or default)RootPathis used viaos.DirFS.Additionally, I've added a
.gitattributewhich specifies the contents offile/testdatato be cloned with LF end of lines. Otherwise, all unit tests fail when cloned on a Windows system because files are converted to CLRF.