Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a custom route to the server? #9

Closed
shirshir opened this issue Apr 27, 2017 · 3 comments
Closed

How to add a custom route to the server? #9

shirshir opened this issue Apr 27, 2017 · 3 comments
Assignees
Milestone

Comments

@shirshir
Copy link

Right now it is not possible to add a custom route to the server, because the HTTP handler is overridden. Is there a way to achieve that? I want to add a route to return a server health check.

@deankarn deankarn self-assigned this Apr 27, 2017
@deankarn
Copy link
Collaborator

Hey @shirshir

Yes you are correct there is currently no way to do that but I see that as a pretty common requirement.

let me think about the best way to expose that functionality and I'll definitely add it.

Off the top of my head, I'd add a new function Handler or HandlerFunc that would accept the webhook and return an http.Handler or http.HandlerFunc and then you can handle it with whatever Mux you wish.

@deankarn deankarn added this to the v3 milestone Apr 27, 2017
@shirshir
Copy link
Author

shirshir commented Apr 27, 2017

Thanks joeybloggs! That seems like a good idea. Maybe also have a look at Alice.

@shirshir
Copy link
Author

Thanks for the quick solution, Dean! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants