Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article reading page doesn't provide link back to main Shiori page #579

Open
axelsimon opened this issue Feb 16, 2023 · 4 comments
Open

Comments

@axelsimon
Copy link

Hi!

Data

  • Shiori version: 1.5.4
  • Database Engine: sqlite
  • Operating system: NixOS 23.05 (pre)
  • CLI/Web interface/Web Extension: Web Interface

Describe the bug / actual behaviour

Clicking on an article opens a new tab to read the article. This tab contains no link back to the main Shiori interface.

Expected behaviour

I expect to be able to go back to the main Shiori interface from an article served by Shiori.

Notes

I get that the idea is to have a main Shiori page and each article open in a new tab. Not having a link back to the main Shiori interface reduces the risk of people ending up with multiple tabs with the main Shiori page open, but not everyone wants to open everything in new tabs all the time :)

@axelsimon axelsimon added the type:bug Something isn't working label Feb 16, 2023
@Monirzadeh
Copy link
Collaborator

@fmartingr somehow I agree. We can do both and user can be select between them in settings.
if you don't have a problem with that (make codebase bigger for this kind of setting) I can do that.
I think open in current tab is better option. User can be always open in new tab.

@fmartingr fmartingr added type:ux tag:no-stale and removed type:bug Something isn't working labels Jul 2, 2023
@fmartingr
Copy link
Member

I just got used to the fact that the article opens in a new tab and just close it when I want to go back to the main Shiori interface. I keep thinking that maybe we should add the readable to the main javascript interface instead of serve that in the backend, but it's some discussion I want to have once I finish the new API (#497). I should sit down and elaborate a proper roadmap too.

@Monirzadeh
Copy link
Collaborator

I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.
Personally, I prefer to keep shiori keep fast as possible. I am tired of all heavy slow project out there.
About roadmap, I like that idea. I suggest review KOReader project. How it is good to organize, maybe you can find good point there.

@fmartingr
Copy link
Member

fmartingr commented Jul 2, 2023

I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.

Yeah, both ways can coexist, but on my mind, if I'm using the JS interface, I'd prefer everything to load that way. Helps making a PWA for mobile devices easier to develop too. But again, just random thoughts on my head.

In this particular case, since we open a new tab for article content, a "go back" equals to a "window.close()".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

3 participants