feat(worker): add ability to manage workers #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 85.38% 86.00% +0.62%
==========================================
Files 122 132 +10
Lines 5386 5754 +368
==========================================
+ Hits 4599 4949 +350
- Misses 648 660 +12
- Partials 139 145 +6
|
plyr4
reviewed
Apr 11, 2023
plyr4
reviewed
Apr 11, 2023
plyr4
reviewed
Apr 11, 2023
plyr4
reviewed
Apr 11, 2023
plyr4
reviewed
Apr 11, 2023
|
LGTM, just some very minor wording tweaks |
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
plyr4
previously approved these changes
Apr 13, 2023
plyr4
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds ability to:
dependent on:
go-vela/sdk-go#218
go-vela/worker#457
go-vela/server#798
also, needs docs PR