Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci/build): use matrix for builds #452

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

wass3rw3rk
Copy link
Member

@wass3rw3rk wass3rw3rk commented May 19, 2023

should add a little speed boost for running the build workflow. it will parallelize building for each platform when possible - could even add arch into the mix.

ref: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

opportunity to do the same for release builds (on release/tag events). make build is baked into the release.sh script, so might need a bit of rework.

UPDATE:
comparing the build in this PR with the matrix addition versus another, it looks like we're shaving off almost 10 minutes of build time.

before

image

after

image

@wass3rw3rk wass3rw3rk requested a review from a team as a code owner May 19, 2023 16:25
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #452 (74cefb6) into main (e9c1fdf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         133      133           
  Lines        5815     5815           
=======================================
  Hits         5001     5001           
  Misses        666      666           
  Partials      148      148           

@wass3rw3rk wass3rw3rk self-assigned this May 19, 2023
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@wass3rw3rk wass3rw3rk merged commit 6c2ba2b into main May 24, 2023
@wass3rw3rk wass3rw3rk deleted the chore/ci/use-matrix branch May 24, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants