chore(patch-release-prep): upgrade modules with caveats #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.20.2-patch #477 +/- ##
=================================================
+ Coverage 86.41% 86.43% +0.01%
=================================================
Files 145 145
Lines 6302 6301 -1
=================================================
Hits 5446 5446
+ Misses 700 699 -1
Partials 156 156
📢 Have feedback on the report? Share it here. |
wass3rw3rk
approved these changes
Sep 7, 2023
plyr4
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, unbeknownst to me, the current
v0.20.2version of go-vela/server does not include the changes toCompileLitethat were introduced in thev0.20.1release.So I've adjusted
vela validate pipelineto still include a max template depth so they can be ran, but local templates will not be part of the compiler, rather they'll be sourced like they used to be. I don't believe this is breaking, but something to keep an eye on.