fix(schema): stages don't require name field

[wass3r]

name is set to key if not supplied as evidenced by: https://github.com/go-vela/types/blob/master/yaml/stage.go#L78

[codecov]

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          44       44           
  Lines        3096     3096           
=======================================
  Hits         3086     3086           
  Misses          6        6           
  Partials        4        4           

Impacted Files	Coverage Δ
yaml/stage.go	100.00% <ø> (ø)

[kneal]

Do you have an example of where that’s true? I thought that field was required since the compiler has some dependencies on it. https://github.com/go-vela/compiler/blob/master/compiler/native/transform.go#L20

[wass3r]

not sure i understand. based on our example in the docs: https://go-vela.github.io/docs/concepts/pipeline/stages/#syntax and my own usage, it's not required to supply name for your stage. the key will be used if no stage name was supplied, as long as we use the unmarshall function on the struct, which it should every time we use yaml.Unmarshal. maybe i'm missing something.

[jbrockopp]

LGTM

[kneal]

@wass3r Yeah, you're right looks like it gets implicitly set
https://github.com/go-vela/types/blob/master/yaml/stage.go#L76-L79

[kneal]

LGTM 🐬

[wass3r]

Cool, yea.. we require it internally, but from a user's perspective it's optional. sorry for confusion.

[kneal]

No problem! I just remembered seeing the name: be used in areas of the compiler and didn’t think to look if we implicitly set it when it’s missing.