Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(status): only match when status exists #72

Merged
merged 2 commits into from
May 21, 2020
Merged

fix(status): only match when status exists #72

merged 2 commits into from
May 21, 2020

Conversation

kneal
Copy link

@kneal kneal commented May 21, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         2640      2646    +6     
=========================================
+ Hits          2640      2646    +6
Impacted Files Coverage Δ
pipeline/container.go 100.00% <100.00%> (ø)
pipeline/ruleset.go 100.00% <100.00%> (ø)

@kneal kneal self-assigned this May 21, 2020
@kneal kneal added the bug Indicates a bug label May 21, 2020
@kneal kneal marked this pull request as ready for review May 21, 2020 12:33
@kneal kneal requested a review from a team as a code owner May 21, 2020 12:33
@wass3r wass3r changed the title bug: only match when status exists fix(status): only match when status exists May 21, 2020
wass3r
wass3r previously approved these changes May 21, 2020
View reviewed changes
jbrockopp
jbrockopp previously approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kneal kneal dismissed stale reviews from jbrockopp and wass3r via e766158 May 21, 2020 13:12
jbrockopp
jbrockopp approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit 840634e into master May 21, 2020
@wass3r wass3r deleted the bug/status branch May 21, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@jbrockopp jbrockopp jbrockopp approved these changes

Assignees

@kneal kneal

Labels
bug Indicates a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kneal @wass3r @jbrockopp