Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to use the label flag #39

Closed
kneal opened this issue Apr 30, 2020 · 1 comment
Closed

Add the ability to use the label flag #39

kneal opened this issue Apr 30, 2020 · 1 comment
Labels
enhancement Indicates an improvement to a feature good first issue Good for newcomers

Comments

@kneal
Copy link

kneal commented Apr 30, 2020 •
edited
Loading

Description

What is your idea?

Add the ability to use the label flag in kaniko

Flag documentation:
https://github.com/GoogleContainerTools/kaniko/#--label

Value

Why is this important? Who does it impact? Will this make something better, faster, etc?

Customers using the docker CLI may be adding custom labels to their images the --label will allow us to have support for kaniko's equivalent flag.

Definition of Done

What is the end goal of this story?

The flag is useable in the plugins
@kneal kneal added enhancement Indicates an improvement to a feature good first issue Good for newcomers labels Apr 30, 2020
@sudohikumar sudohikumar mentioned this issue May 6, 2020
Merged
@jbrockopp
Copy link
Contributor

go-vela/vela-docker#44

This is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Indicates an improvement to a feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockopp @kneal