Feature request: support subquery as a condition value

[damnever]

Expr seems not good enough..

subb := builder.Select("id").From("table_b").Where(builder.And(builder.Eq{"b": "a"}))
b := builder.Select("a, b").From("table_a").Where(
    builder.And(builder.Eq{
        "id":   23,
        "b_id": subb,
    }),
)
sql, args, err := b.ToSQL()
// args will contain the args from subquery:
//  subsql, subargs, err := subb.ToSQL()
//  args = append(args, subargs...)

fmt.Println(sql)
fmt.Println(args)
fmt.Println(err)

Expected output:

SELECT a, b FROM table_a WHERE id=? AND b_id=(SELECT id FROM table_b WHERE b=?)
[23 "a"]
<nil>

[damnever]

I found a solution, anyway, support the Builder as the value directly will be nice..

subsql, subargs, err := builder.Select("id").From("table_b").Where(builder.And(builder.Eq{"b": "a"})).ToSQL()

b := builder.Select("a, b").From("table_a").Where(
        builder.And(builder.Eq{
                "id": 23,
                "b_id": builder.Expr(subsql, subargs...),
        }),
)
sql, args, err := b.ToSQL()
fmt.Println(sql)
fmt.Println(args)
fmt.Println(err)

[lunny]

That's a method but not a good idea. I think treat Builder as a subquery is a better idea for performance.

[damnever]

The issue doesn't actually exists, my bad..

[lunny]

Yes, this feature has been implemented. See the test a4a881a