lock: clear the in-memory lock flag if we failed to acquire a flock. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, didn't see https://github.com/camlistore/go4/pull/7/files when I filed the PR. Feel free to close if it's duplicated |
Also add a test to verify that a second Lock() will succeed after the first one fails.
|
yes, this looks like the same as https://review.gerrithub.io/260449 |
|
@mpl Thank you |
|
Close as #7 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @bradfitz mentioned in camlistore/lock#12 (comment) , the package is moved here, but from the code, it seems the behavior is still the same here.
This PR clears the in-memory map entry when the locking action fails. It also wraps the mutex and map into a struct for cleanness.
Also added a test to verify that a second Lock() can still succeed if the first one fails.