Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support branch searching #206

Merged
merged 1 commit into from
Jan 15, 2020
Merged

feat: support branch searching #206

merged 1 commit into from
Jan 15, 2020

Conversation

bitpshr
Copy link
Contributor

@bitpshr bitpshr commented Jan 15, 2020

This pull request updates the branches.list endpoint to support name-based searches when using the API transport.

References #202
Requires https://github.com/goabstract/projects/pull/3891

@bitpshr bitpshr requested a review from tommoor January 15, 2020 21:17
@bitpshr bitpshr mentioned this pull request Jan 15, 2020
Closed
tommoor
tommoor approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitpshr
Copy link
Contributor Author

bitpshr commented Jan 15, 2020

@tommoor: This requires https://github.com/goabstract/projects/pull/3891 if you have a chance to check that out as well.

@bitpshr bitpshr merged commit 2517a8d into master Jan 15, 2020
@bitpshr bitpshr deleted the feat/branch-search branch January 15, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitpshr @tommoor