Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

Goad is not vendorable. #32

Open
nxvl opened this issue Jun 20, 2016 · 6 comments
Open

Goad is not vendorable. #32

nxvl opened this issue Jun 20, 2016 · 6 comments
Assignees

Comments

@nxvl
Copy link

nxvl commented Jun 20, 2016

When using go as a dependency and vendoring it the following errors appears in the project:

vendor/github.com/goadapp/goad/infrastructure/infrastructure.go:49: undefined: Asset

This is related to the bin-data pre-requisite on build time, which needed and result files are ignored in .gitignore, thus not copied over to vendor/

@jcxplorer
Copy link
Member

@nxvl Do you have any suggestions on how to fix this? Would having the bin-data files in the repo be the only solution?

@nxvl
Copy link
Author

nxvl commented Jun 20, 2016

What i ended up doing was generating infrastructure/bindata.go on the goad repository, copied it over to the vendor/ path it belongs and remove it from the .gitignore file copied over by godeps. Maybe there is an easier way, i'm fairly new to go TBH.

@zeph
Copy link
Member

zeph commented Aug 2, 2017

@cwaltken-edrans please review it when u have time

@cwaltken-edrans
Copy link
Collaborator

Goad is not vendor-able right now due to the dependency on go-bindata bundling the lambda-function as an asset into the goad binary.
Resolving this requires a change in the build and deploy/bundling process. Basically the lambda-function of the default runner needs to be included as a separate asset for this to be working.
Goad was not designed to be used as a library, but we could get there in the near future.

@gserra-olx
Copy link
Contributor

@nxvl is it something u might want/can contribute a patch eventually?

@nxvl
Copy link
Author

nxvl commented Aug 2, 2017

@gserra-olx at this point we already ditched goad from our project, so i'm afraid i won't be able to properly tests it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants