Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3083: properly generate attributes with meta struct:pkg:path #3084

Merged
merged 21 commits into from
Jul 12, 2022

Commits on Jun 28, 2022

  1. Fixes goadesign#3083: properly generate attributes with meta `struct:…

    …pkg:path`
    
    What was the issue?
    
    What was meant to be a check on the parentPkg to avoid recursive
    definitions wasn't actually checking the parent package, but the package
    of the field itself.
    
    It was a bug that got introduced in goadesign#3022 and never worked as expected.
    
    Solution:
    
    Injecting the parent package for the initial definition seems to address
    this.
    Ernesto Jiménez committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    83d283b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    533c669 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Properly handle complex union types (goadesign#3080)

    during marshaling/unmarshaling
    raphael committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    3a5cc25 View commit details
    Browse the repository at this point in the history
  2. Prepare v3.7.7

    raphael committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    43cefd6 View commit details
    Browse the repository at this point in the history
  3. Release v3.7.7

    raphael committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    482fc26 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    56c9300 View commit details
    Browse the repository at this point in the history
  5. Prepare v3.7.8

    raphael committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    4147c92 View commit details
    Browse the repository at this point in the history
  6. Release v3.7.8

    raphael committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    86cc104 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Configuration menu
    Copy the full SHA
    0ce4ff1 View commit details
    Browse the repository at this point in the history
  2. Prepare v3.7.9

    raphael committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    ddf8456 View commit details
    Browse the repository at this point in the history
  3. Release v3.7.9

    raphael committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    aae8ef4 View commit details
    Browse the repository at this point in the history
  4. Prepare v3.7.10

    raphael committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    09f4afb View commit details
    Browse the repository at this point in the history
  5. Release v3.7.10

    raphael committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    bdc5413 View commit details
    Browse the repository at this point in the history
  6. failing server encoding test

    Ernesto Jiménez committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    5f1d918 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Upgrade to Go 1.18 (goadesign#3088)

    * Upgrade to Go 1.18
    
    * Use Go 1.18 in CI
    
    * sudo does not exist on Windows
    raphael committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    fa267b0 View commit details
    Browse the repository at this point in the history
  2. Only generate validation methods when required (goadesign#3089)

    The prior code didn't always take into consideration
    the case where a type has a required validation that
    does not apply (e.g. object with only primitive types
    that are not pointers).
    
    This refactor moves the logic to a common method
    that handles all corner cases.
    raphael committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    4bceaee View commit details
    Browse the repository at this point in the history
  3. Fixes goadesign#3083: properly generate attributes with meta `struct:…

    …pkg:path`
    
    What was the issue?
    
    What was meant to be a check on the parentPkg to avoid recursive
    definitions wasn't actually checking the parent package, but the package
    of the field itself.
    
    It was a bug that got introduced in goadesign#3022 and never worked as expected.
    
    Solution:
    
    Injecting the parent package for the initial definition seems to address
    this.
    Ernesto Jiménez authored and raphael committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    0d905a2 View commit details
    Browse the repository at this point in the history
  4. Update codegen/scope.go

    ernesto-jimenez authored and raphael committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    e6da885 View commit details
    Browse the repository at this point in the history
  5. failing server encoding test

    Ernesto Jiménez authored and raphael committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    60edf07 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Fix marshalling function argument type packages

    When using "struct:pkg:path"
    raphael committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    ac87013 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix-struct-pkg-path' of ssh://github.com/ernesto-jimene…

    …z/goa into fix-struct-pkg-path
    raphael committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    e01aa87 View commit details
    Browse the repository at this point in the history