Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor inconsistencies in generated data-access interfaces #97

Closed
xeger opened this issue May 10, 2016 · 0 comments
Closed

minor inconsistencies in generated data-access interfaces #97

xeger opened this issue May 10, 2016 · 0 comments

Comments

@xeger
Copy link
Contributor

xeger commented May 10, 2016

Some issues that I found peculiar, which slightly detracted from gorma's awesome usability:

  1. List() methods don't return an error (they log it) whereas other methods do

  2. Whereas gorm composition methods return a *gorm.DB, gorma data-access objects always want a gorm.DB (and internally store a DB). This requires me to add a lot of extra * when building queries. Granted, there is no performance or safety difference between using DB and *DB; still, it seems like gorma should be consistent with the framework it wraps.

As discussed in #goa @ gophers.slack.com, these both seem worthy of fixing and I hope to whip up a PR sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants