You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some issues that I found peculiar, which slightly detracted from gorma's awesome usability:
List() methods don't return an error (they log it) whereas other methods do
Whereas gorm composition methods return a *gorm.DB, gorma data-access objects always want a gorm.DB (and internally store a DB). This requires me to add a lot of extra * when building queries. Granted, there is no performance or safety difference between using DB and *DB; still, it seems like gorma should be consistent with the framework it wraps.
As discussed in #goa @ gophers.slack.com, these both seem worthy of fixing and I hope to whip up a PR sometime soon.
The text was updated successfully, but these errors were encountered:
Some issues that I found peculiar, which slightly detracted from gorma's awesome usability:
List()
methods don't return an error (they log it) whereas other methods doWhereas gorm composition methods return a
*gorm.DB
, gorma data-access objects always want agorm.DB
(and internally store aDB
). This requires me to add a lot of extra*
when building queries. Granted, there is no performance or safety difference between usingDB
and*DB
; still, it seems like gorma should be consistent with the framework it wraps.As discussed in #goa @ gophers.slack.com, these both seem worthy of fixing and I hope to whip up a PR sometime soon.
The text was updated successfully, but these errors were encountered: