Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoLayout() should lay out External() elements outside the enterprise (group) boundary #648

Open
abhakhi opened this issue Mar 10, 2024 · 6 comments

Comments

@abhakhi
Copy link

abhakhi commented Mar 10, 2024

Looks like AutoLayout() currently shows External() elements within the enterprise (group) boundary in the SystemLandscapeView() by default. Is there any way to show them outside (without manual positioning)? If not, would be nice if it shows such elements outside the boundary instead, if the boundary is visible (EnterpriseBoundaryVisible()).

@raphael
Copy link
Member

raphael commented Mar 18, 2024

That makes sense, @dvictor - is that doable?

@dvictor
Copy link
Member

dvictor commented Mar 19, 2024

@raphael, if I remember correctly, we only do auto-layout on our side in the editor. The AutoLayout() DSL is for STZ only. And we don't have control over their layout.

@abhakhi, how do you use Goa model tool?

@dvictor
Copy link
Member

dvictor commented Mar 19, 2024

As for our editor Auto Layout button, unrelated to the AutoLayout() DSL, indeed it doesn't consider grouping in neither ContainerView nor in SystemLandscapeView. There's support in Dagre for compound graphs, so we could give it a try.

@abhakhi
Copy link
Author

abhakhi commented Mar 19, 2024

@abhakhi, how do you use Goa model tool?

@raphael, I am calling the AutoLayout() DSL from my model.go and viewing the model in browser with mdl serve. I did not know it is for STZ only. Now I do realize that it never worked at all (for the editor) and I had (got used) to refreshing the browser (editor) and clicking the Auto Layout button every time I updated the design.

@dvictor
Copy link
Member

dvictor commented Mar 19, 2024

Thanks, @abhakhi , that makes sense.
When time permits, I'll look into adding this grouping functionality.
Thank you for submitting the bug, @abhakhi!

Victor.

@raphael
Copy link
Member

raphael commented Mar 19, 2024

Thank you for looking into it @dvictor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants