Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3382576 by nkoporec: Disable revisions for groups #3517

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

nkoporec
Copy link
Contributor

Problem

When doing a clean install of the latest Open Social (from branch dev-main), revisions are enabled for groups and show up as a tab in the group itself.

Follow up from:
#3486

Solution

Disable revisions as this was not enabled before.

Issue tracker

https://www.drupal.org/project/social/issues/3382576

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  1. Install clean OS
  2. Go to admin/group/types/manage/closed_group
  3. See that Create a new revision when a group is modified checkbox is disabled.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Before:
image

After:
image

Release notes

Disabled revisions for groups.

Change Record

Translations

@nkoporec nkoporec added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Sep 11, 2023
@nkoporec nkoporec added this to the 11.10.1 milestone Sep 11, 2023
@nkoporec nkoporec force-pushed the bug/disable-revisions-for-groups-2 branch from 820c0b1 to 71e357e Compare September 11, 2023 17:20
@mergeable
Copy link

mergeable bot commented Sep 11, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@nkoporec nkoporec merged commit 85489fb into main Sep 11, 2023
189 checks passed
@nkoporec nkoporec deleted the bug/disable-revisions-for-groups-2 branch September 11, 2023 18:31
@nkoporec
Copy link
Contributor Author

🍒 picked to 11.10.x

@tbsiqueira tbsiqueira added backport: verified This pull request has been back ported to an older minor version status: no action needed and removed status: needs review This pull request is waiting for a requested review labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium team: guardians type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

2 participants