Issue #3382576 by nkoporec: Disable revisions for groups #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoporec
added
status: needs review
|
Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊 |
|
Hi @nkoporec, I follow the HTT and sadly the "Create a new revision when a group is modified" option is disabled: |
|
@BiaInacio This is correct as per screenshot, the option should be disabled and the "Revisions" tab should not be visible when viewing the group stream pages. |
|
Hi @nkoporec, |
tbsiqueira
approved these changes
Sep 11, 2023
…al_group_flexible_group\Plugin\views\filter\FlexibleGroupNodeAccess
…ode_access" table for nodes with "public" visibility
Currently translated at 98.4% (3361 of 3415 strings) Co-authored-by: Greenwire Team CH <greenwire@greenpeace.ch> Translate-URL: https://translate.getopensocial.com/projects/gpch/distribution/de_CH/ Translation: Greenpeace Switzerland/Distribution
Currently translated at 49.5% (1670 of 3372 strings) Translated using Weblate (German) Currently translated at 56.1% (1916 of 3415 strings) Co-authored-by: Henrique Ciolfi <henrique.ciolfi@greenpeace.org> Co-authored-by: Owusu-Debrah Boateng <oboateng@greenpeace.org> Co-authored-by: Weblate <noreply@weblate.org> Translate-URL: https://translate.getopensocial.com/projects/gpbr/distribution/pt_BR/ Translate-URL: https://translate.getopensocial.com/projects/gpde/distribution/de/ Translation: Greenpeace Brazil/Distribution Translation: Greenpeace Germany/Distribution
Currently translated at 50.0% (1686 of 3372 strings) Co-authored-by: Henrique Ciolfi <henrique.ciolfi@greenpeace.org> Translate-URL: https://translate.getopensocial.com/projects/gpbr/distribution/pt_BR/ Translation: Greenpeace Brazil/Distribution
These fields have a different field type and value structure than the `datetime` fields that we already tackled in a previous commit, so we need to add them separately.
We sometimes use PHPStan outside of update hooks but this is prone to hard to debug errors which is why we shouldn't do it. This adds a PHPStan hook (with test coverage) to allow `executeUpdate` calls from a `hook_update_N` but not in other functions.
This allows us to use the same structure but it ensures that we can clean up our update path or change our installation independently of the other.
This allows them to be more easily ignored and allows someone to just start writing in the template rather than having to replace or remove text.
The id() method of EntityInterface can return: string|int|null. So, is_int() check will be always false and we will have empty result in exported CSV
…rrent date is equal to the end date
Currently translated at 98.2% (3342 of 3400 strings) Co-authored-by: Greenwire Team CH <greenwire@greenpeace.ch> Translate-URL: https://translate.getopensocial.com/projects/gpch/distribution/de_CH/ Translation: Greenpeace Switzerland/Distribution
Currently translated at 98.2% (3342 of 3400 strings) Co-authored-by: Greenwire Team CH <greenwire@greenpeace.ch> Translate-URL: https://translate.getopensocial.com/projects/gpch/distribution/de_CH/ Translation: Greenpeace Switzerland/Distribution
Currently translated at 50.0% (1703 of 3400 strings) Translated using Weblate (Dutch) Currently translated at 99.1% (3403 of 3432 strings) Co-authored-by: Bram ten Hove <bram.ten.hove@goalgorilla.com> Co-authored-by: Henrique Ciolfi <henrique.ciolfi@greenpeace.org> Co-authored-by: Weblate <noreply@weblate.org> Translate-URL: https://translate.getopensocial.com/projects/gpbr/distribution/pt_BR/ Translate-URL: https://translate.getopensocial.com/projects/open-social/distribution/nl/ Translation: Greenpeace Brazil/Distribution Translation: Open Social/Distribution
Currently translated at 56.3% (1917 of 3400 strings) Co-authored-by: Clara Corpus <clara.corpus@greenpeace.org> Translate-URL: https://translate.getopensocial.com/projects/gpde/distribution/de/ Translation: Greenpeace Germany/Distribution
Currently translated at 50.1% (1706 of 3400 strings) Co-authored-by: Henrique Ciolfi <henrique.ciolfi@greenpeace.org> Translate-URL: https://translate.getopensocial.com/projects/gpbr/distribution/pt_BR/ Translation: Greenpeace Brazil/Distribution
Currently translated at 0.1% (1 of 3400 strings) Translated using Weblate (German (de_CH) (de_CH@gpi)) Currently translated at 0.1% (1 of 3400 strings) Translated using Weblate (Dutch) Currently translated at 52.5% (1786 of 3400 strings) Co-authored-by: ST Tabarelli <stefanotabarelli@goalgorilla.com> Co-authored-by: Weblate <noreply@weblate.org> Translate-URL: https://translate.getopensocial.com/projects/gpch/distribution/de_CH@gpi/ Translate-URL: https://translate.getopensocial.com/projects/gpch/distribution/fr_CH@gpi/ Translate-URL: https://translate.getopensocial.com/projects/gpnl/distribution/nl/ Translation: Greenpeace Netherlands/Distribution Translation: Greenpeace Switzerland/Distribution
Currently translated at 50.2% (1708 of 3400 strings) Co-authored-by: Henrique Ciolfi <henrique.ciolfi@greenpeace.org> Translate-URL: https://translate.getopensocial.com/projects/gpbr/distribution/pt_BR/ Translation: Greenpeace Brazil/Distribution
…king duplication of enrollees and organisers Issue #3377397 by Kovalskiy266: Change name of user in behat test and fix message in MinkContext exception
…moves the flexibility to change it in a different format. In an earlier feature we introduced the option to remove this hardcoded header but we did not provide any default. In this code we set a default for the Open Social product to remove it for specific emails.
…ail notifications
nkoporec
force-pushed
the
bug/disable-revisions-for-groups
branch
from
95db528
to
77cb7d5
Compare
17 tasks
|
New PR: #3517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When doing a clean install of the latest Open Social (from branch dev-main), revisions are enabled for groups and show up as a tab in the group itself.
Solution
Disable revisions as this was not enabled before.
Issue tracker
https://www.drupal.org/project/social/issues/3382576
Theme issue tracker
[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.
How to test
Definition of done
Before merge
After merge
Screenshots
Before:
After:
Release notes
Disabled revisions for groups.
Change Record
Translations