You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Plogon rejects builds that have outputs containg DLLs that Dalamud provides. The way it does this is flawed. This check should be reworked or removed.
Example:
Tourist depends on FFXIVWeather.Lumina (or something similar to that, cba to look up the name). That dependency depends on Lumina from NuGet. This means that Lumina.dll ends up in Tourist's output. However, Tourist's DalamudPackager is configured to exclude that DLL, and the actual output zip doesn't contain it. Plogon blocks this setup from being merged.
There is really very little I can do about this, short of adding a build step to delete DLLs from my output to satisfy an overzealous CI lint.
The text was updated successfully, but these errors were encountered:
Plogon rejects builds that have outputs containg DLLs that Dalamud provides. The way it does this is flawed. This check should be reworked or removed.
Example:
Tourist depends on
FFXIVWeather.Lumina
(or something similar to that, cba to look up the name). That dependency depends onLumina
from NuGet. This means thatLumina.dll
ends up in Tourist's output. However, Tourist'sDalamudPackager
is configured to exclude that DLL, and the actual output zip doesn't contain it. Plogon blocks this setup from being merged.There is really very little I can do about this, short of adding a build step to delete DLLs from my output to satisfy an overzealous CI lint.
The text was updated successfully, but these errors were encountered: