makeHot doesn't accept possible Store parameters

[bebraw]

I was trying to port code such as this.store = alt.createStore(NoteStore, storeName, this.actions); to use makeHot. Sadly it looks like makeHot doesn't allow parameters to be passed to Store. I expect that for this to work you would need to do something like:

function makeHot(alt, Store, name = Store.displayName, parameters) {
  if (module.hot) {
    module.hot.dispose(() => {
      delete alt.stores[name]
    })
  }

  return alt.createStore(Store, name, parameters)
}

export default makeHot

Maybe this was just a simple oversight? I can provide a PR if you want but given it's so trivial change, perhaps just add it there yourself it this makes sense to you.

[bebraw]

As discussed at gitter likely the most sensible solution is to actually integrate this to createStore and then check disable the check when compiling with NODE_ENV is set to production. That way it stays simple from user point of view and the utility can be dropped eventually.

[bebraw]

Do you want a PR for this? I would love to get this resolved as book readers will hit on it for sure. 👍

[goatslacker]

Sure thing!