Implement AddParent() method

[chirino]

No description provided.

[codecov]

Codecov Report

Merging #34 (c662349) into master (02504b0) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   93.86%   94.10%   +0.23%     
==========================================
  Files          16       16              
  Lines         522      543      +21     
==========================================
+ Hits          490      511      +21     
  Misses         21       21              
  Partials       11       11              

Impacted Files	Coverage Δ
container.go	100.00% <100.00%> (ø)
schema.go	96.42% <100.00%> (+1.98%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02504b0...c662349. Read the comment docs.

[chirino]

this would resolved #33

[defval]

@chirino Thanks for the pull request. I will check this tomorrow

[defval]

Do you want the cleanup function to be called for each container separately?

[chirino]

Do you want the cleanup function to be called for each container separately?

Yes. I think the typical usage will have child containers having a shorter lifespan than parents. So I’m not sure we can do much to safeguard proper cleanup. It’s up to the user to clean up parent containers once they are not being used by children.

[defval]

@chirino It looks good. I plan to merge this into the master today and test it a bit on my apps before release

[chirino]

@defval Is it ready for a release yet?

[defval]

@chirino Yes, sorry for delay. I will prepare release today