Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

App is not a singleton but app of scaffolded app should be the only root instance #228

Closed
Tracked by #2332
sio4 opened this issue Sep 27, 2022 · 0 comments · Fixed by #229
Closed
Tracked by #2332

App is not a singleton but app of scaffolded app should be the only root instance #228

sio4 opened this issue Sep 27, 2022 · 0 comments · Fixed by #229
Assignees
Labels
bug Something isn't working s: fixed
Milestone

Comments

@sio4
Copy link
Member

sio4 commented Sep 27, 2022

As reported at gobuffalo/buffalo#1653, in very rare situations, App() can be called multiple times while app is still nil. However, App itself is not a singleton from the perspective of the library (Multihoming or Group uses the same App), it should be prevented by the user's application. (gobuffalo/buffalo#1653 (comment))

The scaffold command buffalo new generates without this prevention, so the template should be updated.

fixes gobuffalo/buffalo#1653

@sio4 sio4 added the bug Something isn't working label Sep 27, 2022
@sio4 sio4 added this to the v1.0.0 milestone Sep 27, 2022
@sio4 sio4 self-assigned this Sep 27, 2022
@sio4 sio4 closed this as completed in #229 Oct 1, 2022
@sio4 sio4 added the s: fixed label Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working s: fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant