Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Incorrect internal version #69

Closed
QuLogic opened this issue Feb 25, 2023 · 4 comments
Closed

bug: Incorrect internal version #69

QuLogic opened this issue Feb 25, 2023 · 4 comments
Assignees
Labels
s: closed s: triage Some tests need to be run to confirm the issue stale

Comments

@QuLogic
Copy link

QuLogic commented Feb 25, 2023

Description

Description

I see that v1.0.1 and v1.0.2 have been tagged, but I noticed that the version in the code is still 1.0.0.

Expected Behavior

flect.Version should be 1.0.2 (or whatever the latest is).

Actual Behavior

https://github.com/gobuffalo/flect/blob/v1.0.2/version.go#L4 is still 1.0.0.

To Reproduce

No response

Additional Context

No response

@sio4
Copy link
Member

sio4 commented Feb 26, 2023

Do you use the value? Curious. What is your purpose for using the value and how do you use it?

Actually, I was going to remove it but if users need it, I need to think about it again.

@sio4 sio4 self-assigned this Feb 26, 2023
@sio4 sio4 added the s: triage Some tests need to be run to confirm the issue label Feb 26, 2023
@QuLogic
Copy link
Author

QuLogic commented Feb 26, 2023

No, I do not. I just noticed it when looking at the diff between 0.3.0 and the latest tag.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days.

@github-actions github-actions bot added the stale label Mar 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This issue was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: closed s: triage Some tests need to be run to confirm the issue stale
Projects
None yet
Development

No branches or pull requests

2 participants