Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Tags provide template helpers ? #72

Closed
paganotoni opened this issue Jan 29, 2018 · 2 comments
Closed

Should Tags provide template helpers ? #72

paganotoni opened this issue Jan 29, 2018 · 2 comments

Comments

@paganotoni
Copy link
Member

@markbates I'm thinking that template helpers that deal with tags (form_for, form, bootstrap versions and others) should be part of Tags and plush would just use those helpers as it is using them now.

Do you agree with this?

@markbates
Copy link
Member

No, I don’t. :)

If you put them in tags then it now has a plush dependency.

If we keep it in plush then it has a tags dependency, which I think is better.

Tags can be used without plush, but the reverse isn’t necessarily true.

@paganotoni
Copy link
Member Author

I was thinking that we could have equal interfaces between Tags and Plush so we don't have any dependency on Plush, but I think I can see your point and don't have any solid argument to put us into all this work, so I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants