Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an error on github.com/gobwas/pool/pbufio with go1.10.1 and tip #45

Closed
jeevatkm opened this issue Apr 24, 2018 · 3 comments
Closed
Labels

Comments

@jeevatkm
Copy link

@gobwas I'm getting an error on go1.10.1 and tip (FYI go1.9.5 is passed) travis build https://travis-ci.org/go-aah/aah/jobs/370367917#L627

# github.com/gobwas/pool/pbufio
../../github.com/gobwas/pool/pbufio/pbufio_go19.go:7:35: writerSize redeclared in this block
	previous declaration at ../../github.com/gobwas/pool/pbufio/pbufio_go110.go:7:35
../../github.com/gobwas/pool/pbufio/pbufio_go19.go:13:35: readerSize redeclared in this block
	previous declaration at ../../github.com/gobwas/pool/pbufio/pbufio_go110.go:11:35

Could you please be unblock it? Thank you.

@jeevatkm
Copy link
Author

WebSocket integration PR build ref https://travis-ci.org/go-aah/aah/builds/370392079

@gobwas
Copy link
Owner

gobwas commented Apr 24, 2018

Hi @jeevatkm, just realized that there was a typo in a +build condition. Thanks for the catch. Fixed now and added 1.10 to the travis.

@gobwas gobwas closed this as completed Apr 24, 2018
@gobwas gobwas added the bug label Apr 24, 2018
@jeevatkm
Copy link
Author

Hello @gobwas Thank you for the fix. now build is happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants