Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 upgrade fails with "handshake error: bad \"Upgrade\" header #55

Closed
rusenask opened this issue Aug 9, 2018 · 6 comments
Closed

Comments

@rusenask
Copy link

rusenask commented Aug 9, 2018

Hi, trying out the new version all ws requests fail with handshake error: bad \"Upgrade\" header.

@rusenask
Copy link
Author

rusenask commented Aug 9, 2018

Update: I suspect it's my problem, as after downgrade it still misbehaves, maybe some middleware :|

@rusenask rusenask closed this as completed Aug 9, 2018
@jjhesk
Copy link

jjhesk commented Feb 20, 2019

handshake error: bad "Upgrade" header
still i have the same problem now.. can you fix that? @gobwas

@gobwas
Copy link
Owner

gobwas commented Feb 21, 2019

@jjhesk Hi, if this is a bug inside ws, for sure I can. Could you provide more details on your problem? Thanks.

@amaresh494
Copy link

@gobwas Hello, I'm getting the same error, when I connect to the WebSocket server using NGINX proxy. Here's how my code looks like,
Screenshot 2021-03-31 at 5 23 14 PM

and NGINX configuration is as below,

location /wsapp/ {
    proxy_pass http://localhost:8080;
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "Upgrade";
    proxy_set_header Host $host;
}

The problem is when I try connecting to the WebSocket server through Nginx proxy, I'm getting the "handshake error: bad "Upgrade" header error on the WebSocket server side.

Please help!

@cristaloleg
Copy link
Collaborator

What is the value of Upgrade header?

@Kiura
Copy link

Kiura commented May 22, 2022

I still am getting this error in May 2022 (v1.1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants