log: short circuit trace logging on the hot path #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
commented
Mar 12, 2018
| @@ -70,6 +70,10 @@ func (h *GlogHandler) Verbosity(level Lvl) { | |||
| atomic.StoreUint32(&h.level, uint32(level)) | |||
| } | |||
|
|
|||
| func (h *GlogHandler) IsLogging(level Lvl) bool { | |||
| return atomic.LoadUint32(&h.level) >= uint32(level) | |||
| } | |||
There was a problem hiding this comment.
Note that it only checks the global verbosity level. glog supports per-module verbosity, which would be more difficult to look up.
treeder
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
logAPI with support for checking the log level directly. This enables short circuiting before callinglog.Trace, avoiding wasting CPU and memory formatting a message and doing internal log handler synchronization. The biggest affect should be in the per-tx sections.The pre-existing
log.Lazyalready addresses the problem somewhat, but requires passing a closure and still goes through the internal synchronization.