core: when adding txs to the pool, pre-compute the sender *before* locking the pool #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
commented
Mar 15, 2018
| // Pre-compute and cache before locking. | ||
| for _, tx := range txs { | ||
| _, _ = types.Sender(ctx, pool.signer, tx) | ||
| } |
There was a problem hiding this comment.
We could add some fine grained parallelism here, like the state processor, but we already have a lot of higher level concurrency going on, and will only have more as the cluster size scales up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sender calculation is costly. Don't do it while holding the lock - get it out of the way beforehand. The
pool.signernever changes, so we don't need the lock to access it.