Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per API-Key Limits #29

Open
jmank88 opened this issue Aug 29, 2018 · 2 comments
Open

Support per API-Key Limits #29

jmank88 opened this issue Aug 29, 2018 · 2 comments
Assignees

Comments

@jmank88
Copy link
Contributor

jmank88 commented Aug 29, 2018

We need to support alternate limits for specific clients. Instead of listing specific IP addresses (like with -nolimit) some sort of api-key included in the header would be more general and flexible (e.g. changing IPs, sharing a single key between multiple machines). The rpm per key could then be specified via a flag whose value is a csv of : separated pairs of key and rpm - <key>:<rpm>. For example:

-limits AKXOXLEK:100,LXKFGODK:10

Perhaps an entry without an rpm value could mean -nolimit, and then we could deprecate the -nolimit flag.

-limits AKOXLEK,LXKFGODK:10

The API key format should remain as flexible as possible (any UTF-8 plaintext?) to maximize compatibility with any generation method.

@jmank88 jmank88 changed the title Support Per-Token Limits Support per API-Key Limits Aug 29, 2018
@jmank88
Copy link
Contributor Author

jmank88 commented Aug 29, 2018

Which HTTP header should we use for the api-key? Is there a standard one that is appropriate?

@treeder
Copy link
Contributor

treeder commented Aug 29, 2018

Authorization header typically.

Authorization: Bearer TOKEN

@jmank88 jmank88 self-assigned this Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants