Fix i18n dashboard language strings and allow customizing of permalink slugs #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eview prompt. Will test undoing these one by one to know what the bare minimum change is.
…nks for the settings page
…slugs, to avoid issues when visiting Settings > Permalink as a user with a different language than the site
…ership catalog is set
…point the defaults have already been loaded, so it has no effect.
… registration hook was fixed as part of this, as it did not run on activation.
brianhogg
commented
Feb 8, 2024
| @@ -89,9 +82,9 @@ private function __construct() { | |||
| $this->query = new LLMS_Query(); | |||
|
|
|||
| // Hooks. | |||
| register_activation_hook( __FILE__, array( 'LLMS_Install', 'install' ) ); | |||
There was a problem hiding this comment.
The register_activation_hook needs the main plugin filename. Since the class filename is being used here, this would never run. It's been moved into the main plugin file instead so the verify_permalinks runs on activation.
brianhogg
commented
Feb 8, 2024
Coverage reportCaution An unexpected error occurred. For more details, check console
Test suite run success169 tests passing in 22 suites. Report generated by 🧪jest coverage report action from e023c83 |
4 tasks
…tions under the current framework, they're not running reliably via github actions.
…language strings in an expected WP location.
brianhogg
changed the title
brianhogg
commented
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various i18n fixes:
Fixes #2324
Fixes #2429
Fixes #2525
How has this been tested?
Manually. The current E2E doesn't permit tests before LifterLMS has been loaded, and switching languages was flaky.
Screenshots
Checklist: