Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n dashboard language strings and allow customizing of permalink slugs #2593

Merged
merged 36 commits into from
Apr 16, 2024
Merged

Fix i18n dashboard language strings and allow customizing of permalink slugs #2593

merged 36 commits into from
Apr 16, 2024

Commits on Feb 5, 2024

  1. Working version of fixing the admin menu items, and things like the r… 

    …eview prompt. Will test undoing these one by one to know what the bare minimum change is.
    @brianhogg
    brianhogg committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    13bae57 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Undoing changes that aren't required to fix admin menu and notice lan… 

    …guage
    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1cab2bf View commit details
    Browse the repository at this point in the history

  2. Load localize before loading of block settings

    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8da8c62 View commit details
    Browse the repository at this point in the history

  3. WIP: Starting permalink settings with default loading and saved optio… 

    …n structure
    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    48c5e61 View commit details
    Browse the repository at this point in the history

  4. Unload only the given domain not lifterlms each time

    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7b2c0c2 View commit details
    Browse the repository at this point in the history

  5. Refactor to ensure locale set to the site locale when loading permali… 

    …nks for the settings page
    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2a0e6bc View commit details
    Browse the repository at this point in the history

  6. Adding courses archive setting

    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    00914b3 View commit details
    Browse the repository at this point in the history

  7. Removing old WP < 5.0 code

    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    765ee77 View commit details
    Browse the repository at this point in the history

  8. Do not use the translations for the courses (single and archive) url … 

    …slugs, to avoid issues when visiting Settings > Permalink as a user with a different language than the site
    @brianhogg
    brianhogg committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f68970e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Adding remaining always-show slug translation options

    @brianhogg
    brianhogg committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bba738f View commit details
    Browse the repository at this point in the history

  2. Adding membership base

    @brianhogg
    brianhogg committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4254dee View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Removing unneeded whitespace

    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    139981b View commit details
    Browse the repository at this point in the history

  2. Conditionally show archive page and helpful message if course or memb… 

    …ership catalog is set
    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    188d03b View commit details
    Browse the repository at this point in the history

  3. Removing locale switch when loading the permalink structure. By this … 

    …point the defaults have already been loaded, so it has no effect.
    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    dfa67c3 View commit details
    Browse the repository at this point in the history

  4. Saving permalink settings

    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ed5c66b View commit details
    Browse the repository at this point in the history

  5. On update, ensure the slug defaults are set in the site language. The… 

    … registration hook was fixed as part of this, as it did not run on activation.
    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f9da343 View commit details
    Browse the repository at this point in the history

  6. Formatting fixes

    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    dfbe58a View commit details
    Browse the repository at this point in the history

  7. PHPCS Fix. May want to ignore this.

    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6708b91 View commit details
    Browse the repository at this point in the history

  8. Sanitize nonce

    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a1cebbc View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dev' into fix/i18n-dashboard-language-and-slugs

    @brianhogg
    brianhogg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    db1fa28 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Test for slug editing and menu language display

    @brianhogg
    brianhogg committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    acb044f View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Fixing typo when saving lesson base slug

    @brianhogg
    brianhogg committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7b8f705 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Adding domain to slug field labels

    @brianhogg
    brianhogg committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f866e69 View commit details
    Browse the repository at this point in the history

  2. Add option to specify the textdomain, so add-ons can use the locale s… 

    …witching methods
    @brianhogg
    brianhogg committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9d4723e View commit details
    Browse the repository at this point in the history

  3. Fix comment

    @brianhogg
    brianhogg committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3a42a84 View commit details
    Browse the repository at this point in the history

  4. Styling fix

    @brianhogg
    brianhogg committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    34cc161 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Adding plugin and language dirs to switch/restore locale calls

    @brianhogg
    brianhogg committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    23b1427 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Moving permalink load logic into the class itself

    @brianhogg
    brianhogg committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    45cb587 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into fix/i18n-dashboard-language-and-slugs

    @brianhogg
    brianhogg committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    507da92 View commit details
    Browse the repository at this point in the history

  3. Removing E2E tests. Due to tests being inter-dependent and race condi… 

    …tions under the current framework, they're not running reliably via github actions.
    @brianhogg
    brianhogg committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6b927cf View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge branch 'dev' into fix/i18n-dashboard-language-and-slugs

    @brianhogg
    brianhogg committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8626a74 View commit details
    Browse the repository at this point in the history

  2. Avoid checking for file existence when loading script translations

    @brianhogg
    brianhogg committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    c35516e View commit details
    Browse the repository at this point in the history

  3. Adding changelogs

    @brianhogg
    brianhogg committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    2d66d35 View commit details
    Browse the repository at this point in the history

  4. Adding dev changelog

    @brianhogg
    brianhogg committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0c360c1 View commit details
    Browse the repository at this point in the history

  5. Removing test that does not appear to reflect reality of loading the … 

    …language strings in an expected WP location.
    @brianhogg
    brianhogg committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    647716d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'dev' into fix/i18n-dashboard-language-and-slugs

    @ideadude
    ideadude committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e023c83 View commit details
    Browse the repository at this point in the history