Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stmt can't mock test #213

Closed
liamnv opened this issue Apr 23, 2020 · 4 comments
Closed

Update stmt can't mock test #213

liamnv opened this issue Apr 23, 2020 · 4 comments
Labels

Comments

@liamnv
Copy link

liamnv commented Apr 23, 2020

In Update stmt (https://github.com/gocraft/dbr/blob/master/update.go#L10) use map[string]interface, so you can't control map sorting, so query param not as expected, we can't unit testing

@taylorchu
Copy link
Contributor

do you create unit test by comparing statements?

@liamnv
Copy link
Author

liamnv commented Jun 10, 2020

Yes

@17-09
Copy link

17-09 commented Jul 14, 2020

Is there any update?
@taylorchu

@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 12, 2020
@stale stale bot closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants